[vlc-commits] xcb/window: remove unnecessary geometry request

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <***@remlab.net> | Sat Dec 8 15:10:32 2018 +0200| [dde1c24e6b551632e126755076d9c455bb12b6cc] | committer: Rémi Denis-Courmont

xcb/window: remove unnecessary geometry request

There is always a configure event when creating a new window.
Even if there were not, the logic was race-prone.

http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=dde1c24e6b551632e126755076d9c455bb12b6cc

---

modules/video_output/xcb/window.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/modules/video_output/xcb/window.c b/modules/video_output/xcb/window.c
index a1eb02dc19..ce4c8fe0e4 100644
--- a/modules/video_output/xcb/window.c
+++ b/modules/video_output/xcb/window.c
@@ -696,15 +696,6 @@ static int Open (vout_window_t *wnd, const vout_window_cfg_t *cfg)
/* Make the window visible */
xcb_map_window (conn, window);

- /* Get the initial mapped size (may differ from requested size) */
- xcb_get_geometry_reply_t *geo =
- xcb_get_geometry_reply (conn, xcb_get_geometry (conn, window), NULL);
- if (geo != NULL)
- {
- vout_window_ReportSize(wnd, geo->width, geo->height);
- free (geo);
- }
-
/* Create the event thread. It will dequeue all events, so any checked
* request from this thread must be completed at this point. */
if (vlc_clone(&sys->thread, Thread, wnd, VLC_THREAD_PRIORITY_LOW))